Skip to content

[mtbank]- Попытка фикса таймаутов #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Kabaye wants to merge 3 commits into
base: master
Choose a base branch
from
+378 −21
Draft

[mtbank]- Попытка фикса таймаутов #1036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a35b8f
fix(mtbank): harden statement sync
Kabaye May 13, 2026
739c146
perf(mtbank): speed up statement loading
Kabaye May 13, 2026
793060a
refactor(mtbank): isolate cookie fix
Kabaye May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
340 changes: 340 additions & 0 deletions src/plugins/mtbank/__tests__/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@ import fetchMock from 'fetch-mock'
import { scrape } from '..'

describe('scrape', () => {
afterEach(() => {
fetchMock.restore()
})

it('should hit the mocks and return results', async () => {
mockIdentity()
mockCheckPassword()
Expand Down Expand Up @@ -85,6 +89,342 @@ describe('scrape', () => {
comment: 'Возврат денежных средств'
}])
})

it('should keep cookies fresh for userRole before parallel statements', async () => {
const seenCookies = {
checkPassword: [],
userRole: [],
loadUser: [],
statements: []
}

fetchMock.once({
method: 'POST',
matcher: (url) => url === 'https://mybank.by/api/v1/login/userIdentityByPhone',
response: {
status: 200,
body: JSON.stringify({
ResponseType: 'ResponseOfUserIdentityByPhoneData',
error: null,
sessionId: null,
success: true,
validateErrors: null,
data: {
smsCode: null,
userLinkedAbs: true
}
}),
statusText: 'OK',
headers: { 'set-cookie': 'identity-cookie=1' },
sendAsJson: false
}
})

fetchMock.once({
method: 'POST',
matcher: (url, { headers }) => {
if (url !== 'https://mybank.by/api/v1/login/checkPassword4') return false
seenCookies.checkPassword.push(headers.Cookie)
return true
},
response: {
status: 200,
body: JSON.stringify({
ResponseType: 'ResponseOfCheckPasswordResponse',
error: null,
sessionId: null,
success: true,
validateErrors: null,
data: {
fingerToken: null,
nextOperation: null,
userInfo: {
email: 'TEST@GMAIL.COM',
firstName: 'Вася',
middleName: 'Петрович',
isCustomLogin: false,
lastName: 'Осюк',
login: 'login',
phone: '',
isResident: true,
dboContracts: [{
contractNum: 'IB_I/123456',
status: 'REGISTERED',
role: 'F',
isAdmin: null,
name: 'Осюк В.П.',
longname: 'Осюк Вася Петрович',
smsConfirmation: false
}]
}
}
}),
statusText: 'OK',
headers: { 'set-cookie': 'password-cookie=1' },
sendAsJson: false
}
})

fetchMock.once({
method: 'POST',
matcher: (url, { headers }) => {
if (url !== 'https://mybank.by/api/v1/user/userRole') return false
seenCookies.userRole.push(headers.Cookie)
return true
},
response: {
status: 200,
body: JSON.stringify({
ResponseType: 'ResponseOfstring',
error: null,
sessionId: null,
success: true,
validateErrors: null,
data: null
}),
statusText: 'OK',
headers: { 'set-cookie': 'role-cookie=1' },
sendAsJson: false
}
})

fetchMock.once({
method: 'GET',
matcher: (url, { headers }) => {
if (url !== 'https://mybank.by/api/v1/user/loadUser') return false
seenCookies.loadUser.push(headers.Cookie)
return true
},
response: {
status: 200,
body: JSON.stringify({
ResponseType: 'ResponseOfUserResponse',
error: null,
sessionId: '1111111111111',
success: true,
validateErrors: null,
data: {
addInfo: [],
products: [{
productType: 'PC',
accountId: '1111111',
id: 1,
productCode: '1111111|PC',
show: true,
variationId: '[MASTERCARD][MCW INSTANT BYR 3Y (PAYOKAY)]',
accruedInterest: null,
avlBalance: '999.9',
avlLimit: null,
cardAccounts: [{
accType: null,
accountId: 'BY36MTBK10110001000001111000',
accountIdenType: 'PC',
availableBalance: null,
contractCode: '1111111',
currencyCode: 'BYN',
productType: 'PC'
}],
cardContract: [{
productType: 'MTBANK_CARD',
closeDate: '2020-01-31',
contractNum: '11111111',
openDate: '2018-01-31',
cardTerm: '11/11',
rateBal: '0.0001',
servicePaySum: null,
servicePayTerm: null,
smsNotification: '1',
tariffPlan: 'PayOkay'
}],
cards: [{
blockReason: null,
cardCurr: 'BYN',
commisDate: '2011-01-31',
commisSum: '1.1',
description: 'MASTERCARD',
embossedName: 'ANDREI IOKSHA',
isOfAccntHolder: '1',
limits: [],
mainCard: '1',
over: '0',
pan: '111111_1111',
smsNotification: '1',
status: 'A',
term: '11/11',
type: 'MASTERCARD',
vpan: '1111111111111111',
rbs: '1111111',
pinPhoneNumber: '111111111111'
}],
debtPayment: null,
debtPaymentSumCom: null,
description: 'PayOkay',
gracePeriodAvalDays: null,
gracePeriodEnd: null,
gracePeriodLength: null,
gracePeriodOutRateCashless: null,
gracePeriodRateCashless: null,
gracePeriodStart: null,
isActive: true,
isOverdraft: false,
loanContractDate: null,
loanContractNumber: null,
loanNextPaymentAmmount: null,
loanNextPaymentDate: null,
minPaymentFee: null,
minPaymentMainDept: null,
minPaymentOverFee: null,
minPaymentOverMainDept: null,
minPaymentOverPer: null,
minPaymentPenalty: null,
minPaymentPer: null,
minPaymentStandardOper: null,
minPaymentStandardOperPer: null,
minPaymentStateDue: null,
minPaymentUBS: null,
over: null,
overStandardOperationRate: null,
overdueDebts: null,
ownFunds: null,
points: '',
pointsDate: null,
productIdenType: null,
rate: '0.0001',
rateAvalInstalment: null,
rateAvalInstalmentHistory: [],
rateCache: null,
rateCacheHistory: [],
rateCacheless: null,
rateCachelessHistory: [],
rateChangingHistory: [],
rateExpirPayment: null,
rateExpirPaymentHistory: [],
standardOperationRate: null
}],
userEripId: null,
userInfo: {
crmId: '1111111111',
email: '',
firstName: 'Иван',
isCustomLogin: false,
lastName: 'Иванов',
login: '1111111111111111111111111111111111',
phone: '111111111111',
isResident: true
}
}
}),
statusText: 'OK',
headers: { 'set-cookie': 'load-user-cookie=1' },
sendAsJson: false
}
})

fetchMock.once({
method: 'POST',
matcher: (url, { headers }) => {
if (url !== 'https://mybank.by/api/v1/product/loadOperationStatements') return false
seenCookies.statements.push(headers.Cookie)
return true
},
response: {
status: 200,
body: JSON.stringify({
ResponseType: 'ResponseOfListOfTransactionStatement',
error: null,
sessionId: null,
success: true,
validateErrors: null,
data: [{
accountCurr: 'BYN',
accountId: 'BY36MTBK10110001000001111000',
avlBalance: '791.3',
client: 'Иванов Иван Иванович',
dateFrom: '2018-12-27',
dateTo: '2019-01-16',
incomingBalance: '999.9',
numDateContract: '11111111 от 1111.11.11',
operations: [{
amount: '29.68',
balance: '531.57',
cardPan: '111111******1111',
curr: 'BYN',
debitFlag: '0',
description: 'Оплата товаров и услуг',
error: '',
operationDate: '2019-01-02',
orderStatus: '1',
place: 'Магазин',
status: 'T',
transAmount: '29.68',
transDate: '2018-12-29 01:07:39',
transactionId: '1111112'
}],
outgoingBalance: '999.9',
receivedAmount: '999.9',
time: '2019-01-16 17:30:49',
writtenOffAmount: '999.9'
}]
}),
statusText: 'OK',
headers: { 'set-cookie': 'statement-cookie-1=1' },
sendAsJson: false
}
})

fetchMock.once({
method: 'POST',
matcher: (url, { headers }) => {
if (url !== 'https://mybank.by/api/v1/product/loadOperationStatements') return false
seenCookies.statements.push(headers.Cookie)
return true
},
response: {
status: 200,
body: JSON.stringify({
ResponseType: 'ResponseOfListOfTransactionStatement',
error: null,
sessionId: null,
success: true,
validateErrors: null,
data: [{
accountCurr: 'BYN',
accountId: 'BY36MTBK10110001000001111000',
avlBalance: '791.3',
client: 'Иванов Иван Иванович',
dateFrom: '2019-01-16',
dateTo: '2019-01-18',
incomingBalance: '999.9',
numDateContract: '11111111 от 1111.11.11',
operations: [],
outgoingBalance: '999.9',
receivedAmount: '999.9',
time: '2019-01-18 17:30:49',
writtenOffAmount: '999.9'
}]
}),
statusText: 'OK',
headers: { 'set-cookie': 'statement-cookie-2=1' },
sendAsJson: false
}
})

const result = await scrape({
preferences: { phone: '123456789', password: 'pass' },
fromDate: new Date('2018-12-27T00:00:00.000+03:00'),
toDate: new Date('2019-01-18T00:00:00.000+03:00')
})

expect(result.accounts).toHaveLength(1)
expect(result.transactions).toHaveLength(1)
expect(seenCookies.checkPassword).toEqual(['identity-cookie=1'])
expect(seenCookies.userRole).toEqual(['identity-cookie=1; password-cookie=1'])
expect(seenCookies.loadUser).toEqual(['identity-cookie=1; password-cookie=1; role-cookie=1'])
expect(seenCookies.statements).toEqual([
'identity-cookie=1; password-cookie=1; role-cookie=1; load-user-cookie=1',
'identity-cookie=1; password-cookie=1; role-cookie=1; load-user-cookie=1'
])
})
})

function mockLoadOperationStatements () {
Expand Down
Loading
Loading