[hapoalim] harden WebView auth recovery after OTP#1038
Open
d0j wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/ServerServices/general/accounts?lang=heaccess instead of requiring immediateSMSESSIONvisibilityopenWebViewAndInterceptRequesthelper pathRoot cause
PR #1030 still assumed that the Android WebView bridge would expose auth cookies immediately and that
SMSESSIONwould always be visible at the moment we tried to recover the session.In practice, two things could still happen:
That left the plugin stuck in the same state: the bank page was authenticated, but sync still treated the login as incomplete.
What changed
ZenMoney.saveCookies().SMSESSIONvisibility; the real success signal is authenticated accounts access.Validation
src/plugins/hapoalim/__tests__/api.login.test.jssrc/plugins/hapoalim/__tests__/api.runtimeHarness.test.jssrc/plugins/hapoalim/__tests__/index.authFlow.test.jsyarn build hapoalimts-standardon changed Hapoalim filestsc --noEmitgit diff --check