Pull Request: Add Arbitrum One Plugin#942
Conversation
|
@dudkitt Hi! Thanks for your contribution. Please fix the code to pass all tests. |
a686609 to
85de5fe
Compare
|
Runtime fix for Arbitrum One plugin: This patch fixes the runtime error "cannot convert BigInt to number" by coercing bigint/string/number inputs in the converter. It also normalizes ETH/token amounts to micro-units (µ = 1e-6), fixes wei→ETH conversion to preserve fractional fees, supports both micro characters (μ/µ), and includes preferences.xml translation to English plus minor lint fixes. Verification: ran |
6238621 to
a686609
Compare
… известных контрактов, удаление неподдерживаемого токена и правильный вывод ETH в микро‑единицах.
Внесённые изменения: нормализован адрес Radiant Capital в merchants.ts (lowercase), удалён CAKE из supportedTokens.ts, в converter.ts переведён вывод wei → µETH (деление на 1e12) и скорректированы расчёты комиссий/транзакций, заменён символ единицы на микро‑знак U+00B5 ('µETH'), обновлены
unit‑тесты и переведены русские комментарии на английский, исправлены ошибки линтера.
c109f47 to
aea3eec
Compare
|
@dudkitt It looks like you’re using https://api.etherscan.io/v2/api as the main api. We already have an Etherscan plugin (https://github.com/zenmoney/ZenPlugins/tree/master/src/plugins/etherscan Could you please consider extending the existing etherscan plugin to support your target chain instead of creating a separate implementation? |
Adding the Arbitrum One network to the existing Etherscan plugin implementation was my "Plan A," which I spent some time developing. Unfortunately, my technical skills weren't sufficient to integrate support for another network without completely redesigning the Etherscan plugin. There were some technical limitations related to the Etherscan plugin being originally written for the older APIv1, which only supported Ethereum. Additionally, we're limited by the free Etherscan API plan. If needed, I can try integrating the new network into the old plugin again. |
Summary
This pull request introduces a new plugin for the Arbitrum One network.
It enables ZenMoney to retrieve balances and transactions for one or multiple wallet addresses using the Arbiscan API.
Features
Implementation Notes
Testing
Why This Matters
Arbitrum One is one of the most widely used L2 networks.
This plugin allows ZenMoney users to track their assets and activity on Arbitrum directly within the app.