fix: use Doctrine metadata even when persist is disabled #841
+46
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikophil
force-pushed
the
fix/use-doctrine-metadata-even-when-persist-disabled
branch
from
0ae9fa6 to
0cab827
Compare
nikophil
changed the title
nikophil
changed the title
nikophil
deleted the
fix/use-doctrine-metadata-even-when-persist-disabled
branch
This was referenced Mar 7, 2025
Merged
nikophil
added a commit
that referenced
this pull request
Mar 10, 2025
* 2.3.x: bot: fix cs [skip ci] fix: bug with factory collectin of persistent factory in unit test (#842) fix: use Doctrine metadata event when persist is disabled (#841) minor: add parameter "withAutoRefresh" to unproxy() function (#840) chore: upgrade also dama when upgrading phpunit version (#839) bot: fix cs [skip ci] changelog: update [skip ci] fix: can call ->create() in after persist callback (#833)
nikophil
added a commit
that referenced
this pull request
Mar 10, 2025
* fix: can call ->create() in after persist callback (#833) * changelog: update [skip ci] * bot: fix cs [skip ci] * chore: upgrade also dama when upgrading phpunit version (#839) * minor: add parameter "withAutoRefresh" to unproxy() function (#840) * fix: use Doctrine metadata event when persist is disabled (#841) * fix: bug with factory collectin of persistent factory in unit test (#842) * bot: fix cs [skip ci] * fix: add missing Test attribute --------- Co-authored-by: nikophil <10139766+nikophil@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #838 (comment)
when persist is disabled with
->withoutPersisting()but persistence still available, we should still rely on Doctrine metadataping @vincentchalamon