Skip to content

Conversation

LukasWoodtli
Copy link

Origin: Silicon Labs Gecko SDK
URL: https://github.com/SiliconLabs/Gecko_SDK
Version: v4.4.6 (SHA: 59d2160fe448b13730a91c0f019a8b4c53c43eb2)
Purpose: Add support for Silicon Labs EXX32 SoCs
License: Zlib
Maintained-by: External

@LukasWoodtli
Copy link
Author

Needed for PR boards: silabs: Support for efm32tg_stk3300

Copy link
Collaborator

@asmellby asmellby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The startup_* files are not needed in Zephyr, since Zephyr has its own way of refining the vector table and reset handler (see prep_c.c).

These files are also ineligible for inclusion in Zephyr due to the license header (for some reason) declaring the MSLA license, which is not an OSI approved open source license.

The combination of these two factors means that you can safely (and must) drop the startup_* files from this PR.

Copy link
Collaborator

@jerome-pouiller jerome-pouiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have some comments about the commit message.

These days, the usual prefix for this kind of changes is gecko: (rather than ext: gecko: ).

Can you add the field commit: (as in the example here) (otherwise, it is not clear you are talking about the sha of the commit or of the files).

I also suggest to change Add support for Silicon Labs EXX32 SoCs in Add support for Silicon Labs EFM32TG SoCs.

@asmellby
Copy link
Collaborator

You will probably need to rebase this in order for CI to pass in the main tree, due to the addition of support for other devices.

@LukasWoodtli LukasWoodtli reopened this Sep 9, 2025
@LukasWoodtli
Copy link
Author

Can this be merged?

Origin: Silicon Labs Gecko SDK
URL: https://github.com/SiliconLabs/Gecko_SDK
Version: v4.4.6
commit: 59d2160fe448b13730a91c0f019a8b4c53c43eb2
Purpose: Add support for Silicon Labs EFM32TG SoCs
License: Zlib
Maintained-by: External

Signed-off-by: Lukas Woodtli <[email protected]>
@jhedberg
Copy link
Member

jhedberg commented Sep 19, 2025

@LukasWoodtli the main tree PR (zephyrproject-rtos/zephyr#91191) should be passing CI before we merge this (besides a manifest check failure as long as it's referencing this PR). You should also take it away from being a Draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants