lib: introduction of the VC8000NanoE video encoder library #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add VC8000NanoE H264 video encoding stack needed by STM32 VENC peripheral to generate H264 compressed bitstream. Signed-off-by: Hugues Fruchet <[email protected]>
Avoid bool redefinition. Signed-off-by: Hugues Fruchet <[email protected]>
Avoid min/max redefinition. Signed-off-by: Hugues Fruchet <[email protected]>
Add debug trace support. Signed-off-by: Hugues Fruchet <[email protected]>
Fix some debug trace points. Signed-off-by: Hugues Fruchet <[email protected]
Trace pointers in hexa instead of decimal. Signed-off-by: Hugues Fruchet <[email protected]>
mathieuchopstm
suggested changes
Jul 9, 2025
There was a problem hiding this comment.
Please drop this file - it's large and unneeded. (Also, I'm a bit worried about licensing...)
erwango
reviewed
Jul 22, 2025
lib/vc8000nanoe/inc/enccommon.h
Outdated
Comment on lines
156
to
161
| #ifndef MAX | ||
| #define MAX(a, b) ((a) > (b) ? (a) : (b)) | ||
| #endif | ||
| #ifndef MIN | ||
| #define MIN(a, b) ((a) < (b) ? (a) : (b)) | ||
| #endif |
There was a problem hiding this comment.
Use of #ifndef is forbidden. See https://docs.zephyrproject.org/latest/contribute/coding_guidelines/index.html#rule-a-3-macro-name-collisions
erwango
reviewed
Jul 22, 2025
There was a problem hiding this comment.
Please add a README filr documenting lib origin, how it is maintained, potential add on fixes. See https://github.com/zephyrproject-rtos/hal_stm32/blob/main/lib/stm32wba/README.rst as exemple
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the VC8000NanoE software stack needed on top of STM32N6 VENC hardware peripheral in order to enable H264 hardware video compression.
This code comes from STM32CubeN6 firmware code located here: https://github.com/STMicroelectronics/STM32CubeN6/tree/main/Middlewares/Third_Party/VideoEncoder/source
Some changes have been made to comply with Zephyr build system and Zephyr kernel defines.
The debug trace system has been adapted and some trace points fixed.
Defining CONFIG_VENC_DEBUG enable printf trace logs.