native_posix: kconfig: Set logging mode conditionally #34141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith-zephyr
requested review from
ulfalizer,
jackrosenthal,
sjg20 and
nordic-krch
github-actions
bot
added
area: Boards
area: native port
keith-zephyr
force-pushed
the
posix-log-fix
branch
from
7374215 to
dda2356
Compare
nashif
approved these changes
Apr 8, 2021
daor-oti
approved these changes
Apr 9, 2021
aescolar
requested changes
Apr 9, 2021
There was a problem hiding this comment.
Thanks. It is a good thing to fix that warning. But it would seem you are not just fixing the warning, but changing the default CONFIG_LOG_MODE_IMMEDIATE to "no" in native_posix.
Would something like this below be better?
index ca8039b399..a226c26d60 100644
--- a/boards/posix/native_posix/Kconfig.defconfig
+++ b/boards/posix/native_posix/Kconfig.defconfig
@@ -45,7 +45,9 @@ config LOG_BACKEND_NATIVE_POSIX
# For native_posix we can log synchronously without any problem
# Doing so will be nicer for debugging
-config LOG_MODE_IMMEDIATE
+choice LOG_MODE
+ default LOG_MODE_IMMEDIATE
+endchoice
endif # LOG
Projects based on native_posix get a warning indicating that the LOG_MODE_IMMEDIATE choice symbol is selected but no symbol ended up as the choice selection. Only set the logging mode if logging is enabled. Signed-off-by: Keith Short <[email protected]>
keith-zephyr
force-pushed
the
posix-log-fix
branch
from
dda2356 to
91e5b75
Compare
Thanks for the suggestion. Done. |
sjg20
approved these changes
Apr 9, 2021
coreboot-bot
pushed a commit
to coreboot/zephyr-cros
that referenced
this pull request
Apr 10, 2021
Projects based on native_posix get a warning indicating that the LOG_MODE_IMMEDIATE choice symbol is selected but no symbol ended up as the choice selection. Only set the logging mode if logging is enabled. Signed-off-by: Keith Short <[email protected]> (cherry picked from commit 91e5b75cbae7d575ff106cfed12395fe98867f9ai zephyrproject-rtos/zephyr#34141) BUG=none TEST=zmake testall Change-Id: Idc676551e4d010595e9f2be76e6bf4dd7fc140cb Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/2818867 Reviewed-by: Jack Rosenthal <[email protected]> Reviewed-by: Simon Glass <[email protected]> Commit-Queue: Simon Glass <[email protected]> Tested-by: Simon Glass <[email protected]>
aescolar
approved these changes
Apr 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Projects based on native_posix get a warning indicating that the
LOG_MODE_IMMEDIATE choice symbol is selected but no symbol ended up as
the choice selection.
Only set the logging mode if logging is enabled.
Signed-off-by: Keith Short [email protected]