samples: subsys: mgmt: support ram load mode with MCUBoot sample on RT1050 EVK #85096
+82
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
butok,
de-nordic,
decsny,
DerekSnell,
dleach02,
EmilioCBen,
kartben,
mmahadevan108,
nashif and
nordicjm
|
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-mcuboot
DNM
nordicjm
previously approved these changes
Feb 4, 2025
nordicjm
reviewed
Feb 4, 2025
Comment on lines
9
to
11
| sram@2003FC00 { | ||
| compatible = "zephyr,memory-region", "mmio-sram"; | ||
| reg = <0x2003FC00 DT_SIZE_K(1)>; |
There was a problem hiding this comment.
Suggested change
| sram@2003FC00 { | |
| compatible = "zephyr,memory-region", "mmio-sram"; | |
| reg = <0x2003FC00 DT_SIZE_K(1)>; | |
| sram@2003FF00 { | |
| compatible = "zephyr,memory-region", "mmio-sram"; | |
| reg = <0x2003FF00 0x100>; |
butok
reviewed
Feb 4, 2025
| @@ -166,6 +166,7 @@ tests: | |||
| integration_platforms: | |||
| - nrf52840dk/nrf52840 | |||
| sample.mcumgr.smp_svr.ram_load: | |||
| sysbuild: true | |||
There was a problem hiding this comment.
It's already defined in the common section, no need to duplicate it.
common:
sysbuild: true
There was a problem hiding this comment.
Good catch- dropped this
fabiobaltieri
added
DNM (manifest)
MCUMgr ram load support was hardcoding the overlay file for the nrf52840dk. To make this support generic, move the _ram_load overlay file to the MCUBoot repository, as part of the mcuboot application. Signed-off-by: Daniel DeGrasse <[email protected]>
MCUBoot RAMLOAD mode relies on CONFIG_XIP=n, but FLASH_MCUX_FLEXSPI_XIP y-selects this symbol. Disable CONFIG_FLASH_MCUX_FLEXSPI_XIP for the case where we are using MCUBoot ramload mode. Signed-off-by: Daniel DeGrasse <[email protected]>
danieldegrasse
force-pushed
the
feature/rt1050-mcuboot-ramload
branch
2 times, most recently
from
52cfb1d to
ba6d537
Compare
Add support for using the ramload mode of MCUBoot on the mimxrt1050_evk Signed-off-by: Daniel DeGrasse <[email protected]>
danieldegrasse
force-pushed
the
feature/rt1050-mcuboot-ramload
branch
from
ba6d537 to
7d2f5f2
Compare
butok
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for running MCUBoot in ram load mode with the RT1050 EVK when using the
smp_svrsample. This requires some rework of the support for thenrf52840dkboard within this sample, because the DTC overlay file for ram load mode was being hardcoded.