-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: github: Add workflow to ensure all GH actions are pinned #87487
ci: github: Add workflow to ensure all GH actions are pinned #87487
Conversation
42e512d
to
0ca1811
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 if it does what it states it does :)
yeah -- tested in my fork and seems to do the job :) |
types: | ||
- edited | ||
- opened | ||
- reopened | ||
- synchronize |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drop, you don't need edited
, that's for rerunning it when the comment is edited, the other three are the default, I'm taking that you copied this block from the compliance workflow, there's a step there that checks that the comment is not empty so it needs edited to work correctly but nothing else should have it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm taking that you copied this block from the compliance workflow
bingo :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry I meant drop the whole block, the one you want are the default, just leave
on:
pull_request:
paths:
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah - done
0ca1811
to
ad5ec03
Compare
This commit introduces a new workflow that checks for SHA-pinned GitHub Actions on pull requests. Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
ad5ec03
to
d4cf5cd
Compare
This commit introduces a new workflow that checks all GitHub Actions in our workflows are SHA-pinned.