drivers: reset: Add generic reset MMIO driver #87501
Open
+299
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a generic reset MMIO driver to be used for devices with a single memory mapped reset bit required to take them out of reset. Signed-off-by: Mohith Potluri <[email protected]>
henrikbrixandersen
requested changes
Mar 21, 2025
Comment on lines
+49
to
+57
| value = sys_read32(config->base); | ||
|
|
||
| if (set) { | ||
| value |= BIT(id); | ||
| } else { | ||
| value &= ~BIT(id); | ||
| } | ||
|
|
||
| sys_write32(value, config->base); |
There was a problem hiding this comment.
Should this be under a lock? E.g. a spinlock?
| # Copyright (c) 2025 Google, LLC | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| description: MMIO Reset |
There was a problem hiding this comment.
This could use a better description.
|
|
||
| description: MMIO Reset | ||
|
|
||
| compatible: "zephyr,reset-mmio" |
There was a problem hiding this comment.
This isn't Zephyr-specific?
| required: true | ||
| num_resets: | ||
| type: int | ||
| default: 1 |
There was a problem hiding this comment.
Defaults need to be described in the textual description.
decsny
reviewed
Mar 22, 2025
| value &= ~BIT(id); | ||
| } | ||
|
|
||
| sys_write32(value, config->base); |
There was a problem hiding this comment.
what about for devices where you need to set and hold and clear the reset line instead of just set and hardware clears
rruuaanng
reviewed
Mar 23, 2025
|
|
||
| /* If active low, invert the logic */ | ||
| if (config->active_low) { | ||
| *status = !*status; |
There was a problem hiding this comment.
Suggested change
| *status = !*status; | |
| *status = !(*status); |
This seems much more relaxed？
| return reset_mmio_update(dev, id, !reset_status); | ||
| } | ||
|
|
||
| static const struct reset_driver_api reset_mmio_driver_api = { |
There was a problem hiding this comment.
Suggested change
| static const struct reset_driver_api reset_mmio_driver_api = { | |
| static DEVICE_API(reset,reset_mmio_driver_api) = { |
Use DEVICE_API macro.
rruuaanng
reviewed
Mar 24, 2025
|
|
||
| ZTEST_SUITE(reset_mmio_tests, NULL, NULL, NULL, NULL, NULL); | ||
|
|
||
| static uint8_t num_resets = 16; |
There was a problem hiding this comment.
Suggested change
| static uint8_t num_resets = 16; | |
| #define RESET_MAX_NUM 16 |
It doesn't look like it's changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a generic reset MMIO driver to be used for devices with a single memory mapped reset bit required to take them out of reset.