Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: i3c: remove group addr definition #87514

Merged
merged 1 commit into from
Mar 25, 2025
Merged

drivers: i3c: remove group addr definition #87514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion doc/hardware/peripherals/i3c.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,6 @@ Configuration Options
Related configuration options:

* :kconfig:option:`CONFIG_I3C`
* :kconfig:option:`CONFIG_I3C_USE_GROUP_ADDR`
* :kconfig:option:`CONFIG_I3C_USE_IBI`
* :kconfig:option:`CONFIG_I3C_IBI_MAX_PAYLOAD_SIZE`
* :kconfig:option:`CONFIG_I3C_CONTROLLER_INIT_PRIORITY`
Expand Down
9 changes: 0 additions & 9 deletions drivers/i3c/Kconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,6 @@ config I3C_SHELL
The I3C shell supports info, bus recovery, CCC, I3C read and
write operations.

config I3C_USE_GROUP_ADDR
bool "Use Group Addresses"
default y
help
Enable this to use group addresses if supported
by the controllers and target devices.

Says Y if unsure.

config I3C_TARGET_BUFFER_MODE
bool "I3C target driver for buffer mode"
help
Expand Down
12 changes: 0 additions & 12 deletions drivers/i3c/i3c_shell.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,9 +200,6 @@ static int cmd_i3c_info(const struct shell *sh, size_t argc, char **argv)
"\tpid: 0x%012llx\n"
"\tstatic_addr: 0x%02x\n"
"\tdynamic_addr: 0x%02x\n"
#if defined(CONFIG_I3C_USE_GROUP_ADDR)
"\tgroup_addr: 0x%02x\n"
#endif
"\tbcr: 0x%02x\n"
"\tdcr: 0x%02x\n"
"\tmaxrd: 0x%02x\n"
Expand All @@ -216,9 +213,6 @@ static int cmd_i3c_info(const struct shell *sh, size_t argc, char **argv)
"\tcrcaps: 0x%02x; 0x%02x",
desc->dev->name, (uint64_t)desc->pid,
desc->static_addr, desc->dynamic_addr,
#if defined(CONFIG_I3C_USE_GROUP_ADDR)
desc->group_addr,
#endif
desc->bcr, desc->dcr, desc->data_speed.maxrd,
desc->data_speed.maxwr,
desc->data_speed.max_read_turnaround,
Expand Down Expand Up @@ -249,9 +243,6 @@ static int cmd_i3c_info(const struct shell *sh, size_t argc, char **argv)
"\tpid: 0x%012llx\n"
"\tstatic_addr: 0x%02x\n"
"\tdynamic_addr: 0x%02x\n"
#if defined(CONFIG_I3C_USE_GROUP_ADDR)
"\tgroup_addr: 0x%02x\n"
#endif
"\tbcr: 0x%02x\n"
"\tdcr: 0x%02x\n"
"\tmaxrd: 0x%02x\n"
Expand All @@ -265,9 +256,6 @@ static int cmd_i3c_info(const struct shell *sh, size_t argc, char **argv)
"\tcrcaps: 0x%02x; 0x%02x",
desc->dev->name, (uint64_t)desc->pid, desc->static_addr,
desc->dynamic_addr,
#if defined(CONFIG_I3C_USE_GROUP_ADDR)
desc->group_addr,
#endif
desc->bcr, desc->dcr, desc->data_speed.maxrd,
desc->data_speed.maxwr,
desc->data_speed.max_read_turnaround,
Expand Down
12 changes: 0 additions & 12 deletions include/zephyr/drivers/i3c.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -946,18 +946,6 @@ struct i3c_device_desc {
*/
uint8_t dynamic_addr;

#if defined(CONFIG_I3C_USE_GROUP_ADDR) || defined(__DOXYGEN__)
/**
* Group address for this target device. Set during:
* - Reset Group Address(es) (RSTGRPA)
* - Set Group Address (SETGRPA)
*
* 0 if group address has not been assigned.
* Only available if @kconfig{CONFIG_I3C_USE_GROUP_ADDR} is set.
*/
uint8_t group_addr;
#endif /* CONFIG_I3C_USE_GROUP_ADDR */

/**
* Bus Characteristic Register (BCR)
* @see @ref I3C_BCR
Expand Down
Loading