Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

driver: i3c: cdns: minor fixes #87515

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −13
Open

driver: i3c: cdns: minor fixes #87515

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fcdbcc7
drivers: i3c: cdns: secondary controllers can do_daa
XenuIsWatching Mar 22, 2025
6cd2782
drivers: i3c: cdns: remove +1 on len for abort limit
XenuIsWatching Mar 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions drivers/i3c/i3c_cdns.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1571,14 +1571,8 @@ static int cdns_i3c_do_daa(const struct device *dev)
{
struct cdns_i3c_data *data = dev->data;
const struct cdns_i3c_config *config = dev->config;
struct i3c_config_controller *ctrl_config = &data->common.ctrl_config;
uint8_t last_addr = 0;

/* DAA should not be done by secondary controllers */
if (ctrl_config->is_secondary) {
return -EACCES;
}

/* read dev active reg */
uint32_t olddevs = sys_read32(config->base + DEVS_CTRL) & DEVS_CTRL_DEVS_ACTIVE_MASK;
/* ignore the controller register */
Expand Down Expand Up @@ -2335,14 +2329,12 @@ static int cdns_i3c_transfer(const struct device *dev, struct i3c_device_desc *t
cmd->cmd0 |= CMD0_FIFO_DEV_ADDR(target->dynamic_addr);
if ((msgs[i].flags & I3C_MSG_RW_MASK) == I3C_MSG_READ) {
cmd->cmd0 |= CMD0_FIFO_RNW;
/*
* For I3C_XMIT_MODE_NO_ADDR reads in SDN mode,
* CMD0_FIFO_PL_LEN specifies the abort limit not bytes to read
*/
cmd->cmd0 |= CMD0_FIFO_PL_LEN(pl + 1);
} else {
cmd->cmd0 |= CMD0_FIFO_PL_LEN(pl);
}
/*
* For I3C_XMIT_MODE_NO_ADDR reads in SDN mode,
* CMD0_FIFO_PL_LEN specifies the abort limit not bytes to read
*/
cmd->cmd0 |= CMD0_FIFO_PL_LEN(pl);

/* Send broadcast header on first transfer or after a STOP. */
if (!(msgs[i].flags & I3C_MSG_NBCH) && (send_broadcast)) {
Expand Down
Loading