Skip to content

Update esptool v5 as an package #92894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

marekmatej
Copy link

@marekmatej marekmatej commented Jul 9, 2025

This PR brings the changes in how the esptool is installed in the system. Instead of hard-copy in the hal/espressif, it put the esptool on the list of required packages. This reflects the new esptool v5.0.0, which comes with several breaking changes.

Copy link

github-actions bot commented Jul 9, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_espressif zephyrproject-rtos/hal_espressif@f3453bd (zephyr) zephyrproject-rtos/hal_espressif#462 zephyrproject-rtos/hal_espressif#462/files

Additional metadata changed:

Name URL Submodules West cmds module.yml Blobs
hal_espressif

DNM label due to: 1 project with PR revision and 1 project with metadata changes

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@github-actions github-actions bot added manifest manifest-hal_espressif DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Jul 9, 2025
@marekmatej marekmatej requested a review from kartben July 9, 2025 12:02
Copy link
Contributor

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought you said you were going to add this dependency in the hal_espressif module?

Something like https://github.com/zephyrproject-rtos/nanopb/blob/master/zephyr/module.yml#L5-L8

@marekmatej
Copy link
Author

marekmatej commented Jul 9, 2025

The current esptool-5.0.0 has a bug that affects some Zephyr builds; therefore, we need to wait for the fix, which will be released as 5.0.1.

@marekmatej marekmatej force-pushed the feature/esptool_v5_package branch 2 times, most recently from e49e04c to f86d481 Compare July 10, 2025 21:40
Marek Matej added 2 commits July 15, 2025 21:33
Brings changes in how esptool is istalled in the environment.

Signed-off-by: Marek Matej <[email protected]>
Updated requirements-actions.in,txt to fetch esptool for the CI.
Fix format of the arguments used in the esptool-5.0.0.

TODO: esptool>=5.0.1 is required, which was not yet released

Signed-off-by: Marek Matej <[email protected]>
@marekmatej marekmatej force-pushed the feature/esptool_v5_package branch from f86d481 to 89cd47f Compare July 15, 2025 19:34
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DNM (manifest) This PR should not be merged (controlled by action-manifest) manifest manifest-hal_espressif
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants