drivers: phy_ksz8081: Fix latency from autonegotiation #93118
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sleep call does not seem necessary and might have been left in by mistake, removing it also removes a ton of latency from the system especially noticeable during boot. Signed-off-by: Declan Snyder <[email protected]>
github-actions
bot
added
area: Ethernet
size: XS
github-actions
bot
requested review from
clamattia,
lmajewski,
maass-hamburg and
pdgendt
maass-hamburg
approved these changes
Jul 14, 2025
|
pdgendt
approved these changes
Jul 15, 2025
clamattia
reviewed
Jul 15, 2025
There was a problem hiding this comment.
Boot should not have to wait on auto-negotiation see for example:
zephyr/drivers/ethernet/phy/phy_mii.c
Line 312 in f52d71c
maass-hamburg
requested changes
Jul 15, 2025
| @@ -127,7 +127,6 @@ static int phy_mc_ksz8081_autonegotiate(const struct device *dev) | |||
| */ | |||
There was a problem hiding this comment.
uint16_t timeout = CONFIG_PHY_AUTONEG_TIMEOUT_MS / 100; from line 101 is no longer right with that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sleep call does not seem necessary and might have been left in by mistake, removing it also removes a ton of latency from the system especially noticeable during boot.