net: l2: wifi: Refactor certificates processing code into common file #93119
Conversation
github-actions
bot
requested review from
jukkar,
krish2718,
MaochenWang1,
pdgendt,
rlubos and
ssharks
This change is to fix the eloop.h header file path. Signed-off-by: Triveni Danda <[email protected]>
D-Triveni
force-pushed
the
refactor_wifi_certs_process
branch
from
d2e696a to
134caa6
Compare
|
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
github-actions
bot
added
manifest
manifest-hostap
DNM (manifest)
Refactor certificate processing code to eliminate duplication and enable reuse across modules that require enterprise support. Signed-off-by: Triveni Danda <[email protected]>
include/zephyr/net/wifi_certs.h
Outdated
| * @param AP or Station mode | ||
| */ | ||
| int wifi_set_enterprise_credentials(struct net_if *iface, | ||
| bool is_ap); |
include/zephyr/net/wifi_certs.h
Outdated
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| #ifndef WIFI_CREDS_H__ |
There was a problem hiding this comment.
fix the guards to match the name
include/zephyr/net/wifi_certs.h
Outdated
| #include <utils/common.h> | ||
| #include <eap_peer/eap_config.h> | ||
| #include <ctrl_iface_zephyr.h> | ||
| #include <wpa_supplicant/config.h> |
There was a problem hiding this comment.
I don't see these being used in this file, please move to C file.
include/zephyr/net/wifi_certs.h
Outdated
| * Clear Wi-Fi enterprise credentials | ||
| * @param Wi-Fi enterprise params |
There was a problem hiding this comment.
has to be doxygen compliant, newline after brief.
| enterprise_creds_params.server_key_len = ARRAY_SIZE(server_key_test); | ||
| } | ||
|
|
||
| void wifi_clear_enterprise_credentials(void) |
There was a problem hiding this comment.
maybe add a comment as to why this is no-op
| @@ -22,247 +22,15 @@ | |||
|
|
|||
| #include <zephyr/net/wifi_credentials.h> | |||
|
|
|||
| #ifdef CONFIG_WIFI_NM_WPA_SUPPLICANT_CRYPTO_ENTERPRISE | |||
There was a problem hiding this comment.
can't we use the new Kconfig itself? WIFI_CERTIFICATE_LIB
subsys/net/l2/wifi/Kconfig
Outdated
| @@ -128,6 +128,10 @@ config WIFI_ENT_IDENTITY_MAX_USERS | |||
|
|
|||
| if WIFI_NM_WPA_SUPPLICANT_CRYPTO_ENTERPRISE | |||
|
|
|||
| config WIFI_CERTIFICATE_LIB | |||
| bool "Process certificates in enterprise mode" | |||
There was a problem hiding this comment.
should we even make this configurable? What happens if use enables Enterprise but disables this?
D-Triveni
force-pushed
the
refactor_wifi_certs_process
branch
from
134caa6 to
1ed0285
Compare
|
hold-off on this till it's confirmed that it's part of 4.2 which I doubt as its too close. |
Refactor certificate processing code to eliminate duplication and enable reuse across modules that require enterprise support.