boards: convert to ARDUINO_HEADER_R3_* macro #94837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
anangl,
butok,
decsny,
DerekSnell,
djiatsaf-st,
dleach02,
EmilioCBen,
erwango,
etienne-lms,
FRASTM,
gautierg-st,
GeorgeCGV,
marwaiehm-st,
mathieuchopstm and
mmahadevan108
mniestroj
force-pushed
the
boards-convert-to-arduino-header-macro
branch
from
a2e94ad to
e7617d2
Compare
etienne-lms
reviewed
Aug 22, 2025
boards/shields/adafruit_2_8_tft_touch_v2/adafruit_2_8_tft_touch_v2_nano.overlay
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull Request Overview
This PR converts Arduino R3 header pin definitions from numeric constants to descriptive macros to improve code readability and reduce errors. The changes replace hardcoded pin numbers (0-21) with self-documenting macros like ARDUINO_HEADER_R3_A0 and ARDUINO_HEADER_R3_D0.
- Standardizes all Arduino R3 connector definitions across STMicroelectronics and u-blox board files
- Adds required header include
<zephyr/dt-bindings/gpio/arduino-header-r3.h>to all affected files - Maintains identical functionality while improving code maintainability
Reviewed Changes
Copilot reviewed 161 out of 161 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Various u-blox board DTS files | Updated GPIO pin mappings from numeric to macro definitions |
| Various STMicroelectronics board DTS files | Updated GPIO pin mappings from numeric to macro definitions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
decsny
previously approved these changes
Aug 27, 2025
Use ARDUINO_HEADER_R3_* macros, as those are much more readable and less error prone. Signed-off-by: Marcin Niestroj <[email protected]>
Use ARDUINO_HEADER_R3_* macros, as those are much more readable and less error prone. Signed-off-by: Marcin Niestroj <[email protected]>
Use ARDUINO_HEADER_R3_* macros, as those are much more readable and less error prone. Signed-off-by: Marcin Niestroj <[email protected]>
Use ARDUINO_HEADER_R3_* macros, as those are much more readable and less error prone. Signed-off-by: Marcin Niestroj <[email protected]>
Use ARDUINO_HEADER_R3_* macros, as those are much more readable and less error prone. Signed-off-by: Marcin Niestroj <[email protected]>
Use ARDUINO_HEADER_R3_* macros, as those are much more readable and less error prone. Signed-off-by: Marcin Niestroj <[email protected]>
mniestroj
force-pushed
the
boards-convert-to-arduino-header-macro
branch
from
e7617d2 to
a3e2074
Compare
|
etienne-lms
approved these changes
Sep 1, 2025
kartben
approved these changes
Sep 2, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
ARDUINO_HEADER_R3_*macros, as those are much more readable and lesserror prone.