-
Notifications
You must be signed in to change notification settings - Fork 7.9k
MCXW23 zephyr base enablement #95290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
MCXW23 zephyr base enablement #95290
Conversation
Hello @AllenZhang-NXP, and thank you very much for your first pull request to the Zephyr project! |
soc/nxp/mcx/mcxw2x/CMakeLists.txt
Outdated
# CMSIS SystemInit allows us to skip enabling clock to SRAM banks via | ||
# this compiler definition | ||
if(NOT DEFINED CONFIG_MCXW23X_SRAM_CLOCKS) | ||
zephyr_compile_definitions(DONT_ENABLE_DISABLED_RAMBANKS=1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 space indent
default 60 | ||
|
||
config SYS_CLOCK_HW_CYCLES_PER_SEC | ||
default 32000000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get from dts value using dt functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can reference this line for an example.
https://github.com/zephyrproject-rtos/zephyr/blob/main/soc/nxp/imxrt/Kconfig.defconfig#L27
You would need to add clock-frequency = 32000000
for the sysclk node in the soc dts file
compatible = "nxp,lpc-syscon"; | ||
reg = <0x0 0x4000>; | ||
#clock-cells = <1>; | ||
reset: reset { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newline line 79, fix in whole PR
if BOOTLOADER_MCUBOOT | ||
choice MCUBOOT_BOOTLOADER_MODE | ||
# Board only supports MCUBoot via "upgrade only" method: | ||
default MCUBOOT_BOOTLOADER_MODE_OVERWRITE_ONLY | ||
endchoice | ||
endif #BOOTLOADER_MCUBOOT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if BOOTLOADER_MCUBOOT | |
choice MCUBOOT_BOOTLOADER_MODE | |
# Board only supports MCUBoot via "upgrade only" method: | |
default MCUBOOT_BOOTLOADER_MODE_OVERWRITE_ONLY | |
endchoice | |
endif #BOOTLOADER_MCUBOOT | |
if BOOTLOADER_MCUBOOT | |
choice MCUBOOT_BOOTLOADER_MODE | |
# Board only supports MCUBoot via "upgrade only" method: | |
default MCUBOOT_BOOTLOADER_MODE_OVERWRITE_ONLY | |
endchoice | |
endif # BOOTLOADER_MCUBOOT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs vastly reducing in size/resolution
#gpio-cells = <2>; | ||
gpio-map-mask = <0xffffffff 0xffffffc0>; | ||
gpio-map-pass-thru = <0 0x3f>; | ||
gpio-map = <0 0 &gpio0 16 0>, /* A0 */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
space after =, not tab
depends on FXLS8974_TRIGGER | ||
|
||
if BOOTLOADER_MCUBOOT | ||
choice MCUBOOT_BOOTLOADER_MODE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apply changes from other commit
3a9127e
to
8810b1d
Compare
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
Fixed the issues mentioned by @nordicjm & the Github CI. |
choice MCUBOOT_BOOTLOADER_MODE | ||
# Board only supports MCUBoot via "upgrade only" method: | ||
default MCUBOOT_BOOTLOADER_MODE_OVERWRITE_ONLY | ||
endchoice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@butok , do we need this defined here and Kconfig.sysbuild
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, both (with & without sysbuild)
The flash write-block-size = <512>
- gpio | ||
- uart | ||
- counter | ||
- flash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i2c
?
CONFIG_UART_INTERRUPT_DRIVEN=y | ||
CONFIG_GPIO=y | ||
CONFIG_ARM_MPU=y | ||
CONFIG_RUNTIME_NMI=y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this added to the defconfig
. I don't see it in a number of the other NXP boards, hence curious why this was added.
- gnuarmemb | ||
supported: | ||
- gpio | ||
- uart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you help to enable the tests/driver/gpio with arduino header?
and enable tests/drivers/uart/uart_basic_api with lpuart loopback as well?
add soc MCX235 and MCXW236 for board frdm_mcxw23 Signed-off-by: Allen Zhang <[email protected]>
add dts for device MCXW235 and MCXW236 Signed-off-by: Allen Zhang <[email protected]>
enable board support for frdm_mcxw23 Signed-off-by: Allen Zhang <[email protected]>
enable board support for mcxw23_evk Signed-off-by: Allen Zhang <[email protected]>
…mcxw23_evk Support arduino_gpio example for NXP frdm_mcxw23 and mcxw23_evk boards. Test using tests/drivers/gpio/gpio_basic_api. Signed-off-by: Allen Zhang <[email protected]>
8810b1d
to
3f88f52
Compare
|
soc: mcxw235,mcxw236: add SOC support for MCXW235 and MCXW236
dts: mcxw235,mcxw236: add dts for MCXW235 and MCXW236
boards: frdm_mcxw23: add frdm_mcxw23 board
boards: mcxw23_evk: add mcxw23_evk board