drivers: i2s: esp32: improve TX robustness and trigger handling #95300
+201
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
anangl,
LucasTambor,
marekmatej,
raffarost,
uLipe and
wmrsouza
1 task
sylvioalves
force-pushed
the
bugfix/esp32-i2s-overrun-fix
branch
from
e987245 to
12043ed
Compare
Treat TX underrun as READY instead of ERROR, so DMA can be restarted. Make START/STOP non-fatal when already in the target state. Auto-start and flush if data is queued, no-op if idle. Allow write() to auto-kick TX when in READY. Signed-off-by: Sylvio Alves <[email protected]>
Split i2s_esp32_trigger_stream() into smaller helper functions (handle_start, handle_stop, handle_drain) to reduce complexity and improve readability. No functional changes. Signed-off-by: Sylvio Alves <[email protected]>
sylvioalves
force-pushed
the
bugfix/esp32-i2s-overrun-fix
branch
from
8d0811e to
1ecd7f1
Compare
|
uLipe
approved these changes
Sep 1, 2025
wmrsouza
requested changes
Sep 3, 2025
There was a problem hiding this comment.
@sylvioalves, treating TX underrun as READY instead of ERROR goes against what is stated in zephyr/include/zephyr/i2s.h:
enum i2s_state {
...
/** TX buffer underrun or RX buffer overrun has occurred. */
I2S_STATE_ERROR,
};
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treat TX underrun as READY instead of ERROR, so DMA can be restarted.
Make START/STOP non-fatal when already in the target state.
Auto-start and flush if data is queued, no-op if idle.
Allow write() to auto-kick TX when in READY.