Some fix-up for NET VLAN #95318
Open
Some fix-up for NET VLAN #95318
+18
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was call trace to execute "net vlan" if vlan interface hadn't been enabled. Fixed it. Signed-off-by: Yangbo Lu <[email protected]>
There were two problems about vlan interface naming currently. 1. When there were more than 1 vlan interfaces. It's not able to initialze name for all of them to same name VLAN-<free>. 2. When enabled vlan with tag, the name VLAN-xxx was used. However we may need to support multiple physical interfaces in the future. So, it's not able to use same name VLAN-xxx either for same tag on different physical interfaces. Signed-off-by: Yangbo Lu <[email protected]>
Used simple vethX for vlan interface name. What interface the vlan interface was attached to could be checked by "net iface" or "net vlan". Signed-off-by: Yangbo Lu <[email protected]>
|
jukkar
reviewed
Sep 2, 2025
| (net_if_l2(iface) == &NET_L2_GET_NAME(VIRTUAL))) { | ||
| static int count; | ||
|
|
||
| snprintk(name, sizeof(name), "veth%d", count++); |
There was a problem hiding this comment.
I would prefer that the default name is vlan%d for the VLAN interfaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fix-up for NET VLAN