scripts: west_commands: build: Fix warning during rebuild #95383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternative solution to #95308 |
zephyrbot
requested review from
carlescufi,
marc-hb,
mbolivar,
pdgendt and
swinslow
pdgendt
previously approved these changes
Sep 3, 2025
carlescufi
previously approved these changes
Sep 3, 2025
5718af0 introduced a regression where a warning was printed about unknown BOARD when rebuilding. Commit moved _find_board() to an earlier stage and that was failing during the rebuild. Instead of moving board finding earlier we can move parsing of the test_item to the later stage as it is needed only just before running cmake. Signed-off-by: Krzysztof Chruściński <[email protected]>
nordic-krch
force-pushed
the
west_build_fix
branch
from
cd3a9d1 to
03b4d85
Compare
|
@pdgendt @carlescufi can you reapprove? I've added blank line as suggested. |
carlescufi
approved these changes
Sep 3, 2025
pdgendt
approved these changes
Sep 3, 2025
|
henrikbrixandersen
approved these changes
Sep 3, 2025
|
@FelixWang47831 I think this change is preferred over #95308 |
|
@pdgendt @nordic-krch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5718af0 introduced a regression where a warning was printed about unknown BOARD when rebuilding. Commit moved _find_board() to an earlier stage and that was failing during the rebuild. Instead of moving board finding earlier we can move parsing of the test_item to the later stage as it is needed only just before running cmake.
This is a regression introduced by #94231