-
Notifications
You must be signed in to change notification settings - Fork 8.1k
boards: renesas: Add support MCUBoot for ek_ra8p1 and mck_ra8t2 #97842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
boards: renesas: Add support MCUBoot for ek_ra8p1 and mck_ra8t2 #97842
Conversation
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add info about MCUboot usage to the board doc? Also, add Kconfig.sysbuild
to board folder with the following
choice BOOTLOADER
default BOOTLOADER_MCUBOOT
endchoice
Update hal_renesas revision to get MCUBoot support Signed-off-by: Khoa Nguyen <[email protected]>
Add support MCUBoot for ek_ra8p1 and mck_ra8t2 Signed-off-by: Khoa Nguyen <[email protected]>
Remove storage_partition definition for Renesas ek_ra8p1, mck_ra8t2 Signed-off-by: Khoa Nguyen <[email protected]>
ed85ac9
to
bb5316e
Compare
Many thanks for your suggestion and the reference. I’ve added the board documentation for MCUboot. However, I prefer not to include |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Will revisit after manifest is merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You still need to add Kconfig.sysbuild
file. (Non-blocking)
Apply remarks to both boards.
.. note:: | ||
|
||
With ``--sysbuild`` option, MCUboot will be re-build and re-flash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With ``--sysbuild`` option, MCUboot will be re-build and re-flash | |
With ``--sysbuild`` option, MCUboot will be re-built and re-flashed |
|
||
With ``--sysbuild`` option, MCUboot will be re-build and re-flash | ||
every time the pristine build is used. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To only flash the user application in the subsequent builds, Use: | |
.. code-block:: console | |
$ west flash --domain hello_world |
|
||
slot1_partition: partition@66000 { | ||
label = "image-1"; | ||
reg = <0x66000 DT_SIZE_K(344)>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be memory efficient, 2nd slot has to be 1 sector larger than the 1st.
https://docs.mcuboot.com/design.html#image-swap-offset-no-scratch
Those should be the exception, not the general default. Also, you can create a dedicated board variant for those. |
|
Hi @nordicjm, @kartben — could we get your thoughts on this? |
MCUboot is optional. You can build an application for the board without MCUboot and it builds, flashes and runs fine right? So having MCUboot disabled by default is perfectly fine |
BOOTLOADER_MCUBOOT
forSOC_RA_ENABLE_START_SECOND_CORE
configek_ra8p1
andmck_ra8t2
storage_partition
definition for Renesasek_ra8p1
,mck_ra8t2
in the testflash/common