posix: deprecate CONFIG_POSIX_API and remove zephyr/posix include prefix #97855
+2,669
−1,325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfriedt
force-pushed
the
deprecate-config-posix-api
branch
from
d6f7dd9 to
c82f505
Compare
8 tasks
zephyrbot
requested review from
aescolar,
andyross,
carlescufi,
dcpleung,
jakub-uC,
jukkar,
keith-packard,
nashif,
pdgendt,
peter-mitsis,
rerickson1,
rlubos,
ssharks,
stephanosio and
ycsin
cfriedt
force-pushed
the
deprecate-config-posix-api
branch
from
c82f505 to
21ab57c
Compare
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
github-actions
bot
added
manifest
manifest-hostap
DNM (manifest)
cfriedt
force-pushed
the
deprecate-config-posix-api
branch
2 times, most recently
from
b9dac21 to
dc6abc8
Compare
|
This change mitigates some code sonar issues (from SonarQube). 1. explicit 'U' after 0xffffffff > A cast shall not remove any const or volatile qualification from the > type of a pointer or reference c:S859 2. check return value from call to pthread_barrierattr_getpshared() > Unused assignments should be removed c:S1854 Signed-off-by: Chris Friedt <[email protected]>
This mitigates a sonarqube warning "Value stored to 'cvalue' is never read" > Unused assignments should be removed c:S1854 https://sonarcloud.io/project/issues?pullRequest=97152&\ open=AZnAZi4C7BgzESPFIGwf&id=zephyrproject-rtos_zephyr Signed-off-by: Chris Friedt <[email protected]>
This change mitigates a sonarqube warning about uninitialized variables. "1st function call argument is an uninitialized value" > Variables should be initialized before use c:S836 https://sonarcloud.io/project/issues?pullRequest=97152&\ open=AZnAZi0m7BgzESPFIGwe&id=zephyrproject-rtos_zephyr Signed-off-by: Chris Friedt <[email protected]>
If C libraries provide conformant POSIX headers, then use the headers provided by the C library. Otherwise, C library maintainers may add `include/zephyr/posix` to their standard search path. Signed-off-by: Chris Friedt <[email protected]>
This change removes the requirement to have `<zephyr/posix/...>` prefixing all standard POSIX includes in Zephyr. The main reason that it was required was due to conflicts between C library time.h, signal.h and the fact that Zephyr posix headers were being somewhat ad-hoc mixed with libc posix headers. Now, any (even partially) POSIX-conformant C libraries are expected to provide their own types, constants, and headers, and Zephyr's implementation uses those definitions. If any definitions are missing, we define them on a per-libc basis. This can also be done out-of-tree, which allows for implementors to take advantage of the `CONFIG_TC_PROVIDES_POSIX..` options. This is likely the last major commit required before we deprecate the `CONFIG_POSIX_API` Kconfig option in favour of POSIX subprofiling \o/ Signed-off-by: Chris Friedt <[email protected]>
Additional workarounds for POSIX compatibility with the arcmwdt toolchain. This commit addresses issues described in the comment linked below. https://github.com/zephyrproject-rtos/zephyr/pull/97152#\ issuecomment-3409956230 Signed-off-by: Chris Friedt <[email protected]>
cfriedt
force-pushed
the
deprecate-config-posix-api
branch
from
e17271c to
88f9291
Compare
|
Fixed, and rebased to avoid merge conflicts. |
|
@nordicjm - in case you are interested, the commit that resolves your issue is here. Please review and remove your nack. Thanks |
jukkar
previously approved these changes
Oct 23, 2025
jhedberg
previously approved these changes
Oct 23, 2025
Include standard headers for POSIX types and functions instead of making implicit declarations. Signed-off-by: Chris Friedt <[email protected]>
Remove the duplicate Kconfig option `CONFIG_POSIX_SYSTEM_INTERFACES` in `lib/posix/Kconfig.profile` that shadows the option in `lib/posix/Kconfig`. Signed-off-by: Chris Friedt <[email protected]>
Remove usage of CONFIG_POSIX_API. Signed-off-by: Chris Friedt <[email protected]>
This change deprecates the Kconfig option `CONFIG_POSIX_API`. It is slated for removal in Zephyr v4.5.0. Signed-off-by: Chris Friedt <[email protected]>
Add release notes about the deprecation of CONFIG_POSIX_API. User should instead use one of the pre-defined POSIX subprofiles CONFIG_POSIX_AEP_CHOICE_BASE CONFIG_POSIX_AEP_CHOICE_PSE51 CONFIG_POSIX_AEP_CHOICE_PSE52 CONFIG_POSIX_AEP_CHOICE_PSE53 and libraries should depend on CONFIG_POSIX_SYSTEM_INTERFACES as well as other POSIX Option Groups, as needed. For more information, please see https://pubs.opengroup.org/onlinepubs/9799919799/xrat/V4_subprofiles.html Signed-off-by: Chris Friedt <[email protected]>
The specification requires that unistd.h (or a file that is included via unistd.h) declare version macros and feature test macros. Feature test macros declarations are also removed from `lib/posix/options/CMakeLists.txt`. Closes zephyrproject-rtos#97949 Signed-off-by: Chris Friedt <[email protected]>
cfriedt
force-pushed
the
deprecate-config-posix-api
branch
from
88f9291 to
9fa199e
Compare
|
github-actions
bot
removed
the
DNM (manifest)
jhedberg
approved these changes
Oct 23, 2025
nashif
approved these changes
Oct 23, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecation of
CONFIG_POSIX_APIDeprecate
CONFIG_POSIX_API.User may choose one of the pre-defined POSIX subprofiles, for simplicity.
Libraries should depend on CONFIG_POSIX_SYSTEM_INTERFACES as well as other POSIX Option Groups, as needed.
Custom Configurations
Of course, instead of, or in addition to, using a pre-defined POSIX subprofile, users can still fully customize their POSIX configuration via Kconfig.
Zephyr's POSIX Kconfig option names correspond 1:1 with official POSIX Option Group names. Simply add a
CONFIG_at the beginning of an Option Group to get the corresponding Kconfig option.For more information on POSIX Subprofiling Option Groups, please see
https://pubs.opengroup.org/onlinepubs/9799919799/xrat/V4_subprofiles.html
Removal of
zephyr/posix/prefix for standard includesThe majority of the changes in this category (~156 files) are mechanical and are contained in the commit posix: remove zephyr/posix in header prefixes. They are approximately equivalent to running this command (with some adjustments).
Originally from #97152, but included here for simplicity, these changes mean that we no longer need to have
include/zephyr/posixin the library search path for C libraries that have (at least partially) conformant POSIX headers. In other words, we use the C library's POSIX headers.Originally added to mitigate C-library conflicts, the
<zephyr/posix/...h>prefix on standard includes has been a thorn in our sides for several years. Since these changes remove the conflicts, opting to use C-library headers (if they exist), we no longer need to namespace those in Zephyr.Depends on
Note
Compliance issues are false positives
Fixes #97949