Skip to content

Issue fixes#60

Merged
yuqu merged 3 commits intomasterfrom
issue-fixes
Jul 10, 2025
Merged

Issue fixes#60
yuqu merged 3 commits intomasterfrom
issue-fixes

Conversation

@yuqu
Copy link
Contributor

@yuqu yuqu commented Jul 2, 2025

Fixes following issues

  • Color variables should defined in the :root selector
  • For text variables, similar to colors, leave 1 empty space between categories separated by comments

@yuqu yuqu requested review from aykutbulca and berkcebi July 2, 2025 19:39
@changeset-bot
Copy link

changeset-bot bot commented Jul 2, 2025

🦋 Changeset detected

Latest commit: b3a90cc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
zeplin-extension-style-kit Patch
tailwind Patch
base-extension Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@aykutbulca aykutbulca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after fixing the failing tests.

@yuqu yuqu force-pushed the issue-fixes branch 2 times, most recently from 980465b to d6380c1 Compare July 5, 2025 07:05
@yuqu yuqu requested a review from aykutbulca July 5, 2025 07:05
@yuqu yuqu merged commit 1aef103 into master Jul 10, 2025
2 checks passed
@yuqu yuqu deleted the issue-fixes branch July 10, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants