fix: add reaction failed on every platform (issue #9) - #10
Merged
Conversation
Any addReaction on a webhook-received message failed: parseMessage used the
Zernio internal message id, but the reactions endpoint forwards the id verbatim
to the platform, which expects its native id. Message.id (and
ReactionEvent.messageId) now carry the platform-native id, matching what REST
fetches and postMessage already return.
Passing an EmojiValue also failed on every platform: the adapter sent
emoji.name ("thumbs_up") where the API expects the unicode character. Emoji are
now normalized through the resolver, which passes raw unicode through.
Fixes #9
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019c8DtXpqqSunXt4rWRQRTy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Issue #9: on v0.5.0 any
addReactionthrows. Two adapter bugs compose so every add-reaction path fails:parseMessagesetMessage.idto the Zernio internal message id, but the reactions endpoint forwards the id verbatim to the platform, which expects its native id (Telegram numeric id, WhatsApp wamid, ...). Reacting to any webhook-received message therefore always got a platform rejection.EmojiValue, the adapter sentemoji.name("thumbs_up") instead of the unicode character, which every platform rejects.What
Message.idandReactionEvent.messageIdnow carry the platform-native id (falling back to the Zernio id), consistent with what REST fetches andpostMessagealready return, so edit/delete/react all work on received messages.addReactionnormalizes emoji through the default resolver:EmojiValue/names become unicode, raw unicode passes through.🤖 Generated with Claude Code
https://claude.ai/code/session_019c8DtXpqqSunXt4rWRQRTy