Skip to content

Conversation

Ahsan144-tech
Copy link

Thank you for making a pull request to ZTM's Animation Nation project. We will review your pull request as soon as we can, but keep in mind we can get very busy during Hacktoberfest.

While you're waiting, please look over this checklist. Feel free to write a description of what you did as well!

What I did

Optional: Edit this to tell us what you did!

Pull request checklist

  • This pull request uses HTML and CSS only and provides a meta.json file.
  • All files in this pull request are in a directory named: <github_username>-<art_name> without the <>.
  • Your pull request contains index.html and styles.css.
    • Your html file is named exactly: index.html
    • Your css file is named exactly: styles.css
  • Your pull request your meta.json with:
    • githubHandle: being your unique github user name,
    • artName : name of your animation
  • Your submission includes at least one animation.
  • Your pull request does not modify any other files in the repository.

Not normally needed

  • Check this if you would like to discuss an improvement besides adding animations

Note: if your pull request makes an improvement besides adding a CSS animation you will need to discuss this with the maintainers. You can help kickstart this process by explaining what your change does and why you are making it in the "What I did" section

What to expect

  • If your pull request meets the checklist requirements it will be approved and merged by a maintainer
  • If your pull request needs some changes. A maintainer will leave a comment requesting changes
  • If your pull request significantly violates the criteria in the checklist it will be closed with feedback.

Copy link

🙏 Thanks for your pull request @Ahsan144-tech, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2980 97 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
4 369 3669

Copy link
Contributor

@LaurelineP LaurelineP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aloha @Ahsan144-tech 🙌
Thanks for your contribution !

I have reviewed your work and added few feedbacks to address.
Also I'd like to add an overall feedback for your project, the current folder project should not include any special character. Please remove the space to provide a correct path string.

Happy coding 🙌

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected extra file for the contribution

The contribution does not expect to have a fourth file or any pictural file content,

  • Please remove the file from your contribution :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTML File naming

  • The html file should be named differently
  • The imported css source file should have a different file name
    See the contribution rule
  • Please rename your files and correct the link element hyperlink reference

Copy link

🙏 Thanks for your pull request @Ahsan144-tech, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2980 97 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
4 369 3669

Copy link

🙏 Thanks for your pull request @Ahsan144-tech, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2980 97 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
4 369 3669

1 similar comment
Copy link

🙏 Thanks for your pull request @Ahsan144-tech, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2980 97 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
4 369 3669

@SohamDas00
Copy link

hey this side Soham Das , i'm searching for repo with hacktoberfest tag will it accept pr for hacktoberfest25?
thanks

@LaurelineP
Copy link
Contributor

Closed for no updates on the PR - feel free to create another one.

@LaurelineP LaurelineP closed this Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants