-
Notifications
You must be signed in to change notification settings - Fork 3.7k
adding my gif #2980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding my gif #2980
Conversation
🙏 Thanks for your pull request @Ahsan144-tech, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aloha @Ahsan144-tech 🙌
Thanks for your contribution !
I have reviewed your work and added few feedbacks to address.
Also I'd like to add an overall feedback for your project, the current folder project should not include any special character. Please remove the space to provide a correct path string.
Happy coding 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected extra file for the contribution
The contribution does not expect to have a fourth file or any pictural file content,
- Please remove the file from your contribution :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HTML File naming
- The html file should be named differently
- The imported css source file should have a different file name
See the contribution rule - Please rename your files and correct the link element hyperlink reference
🙏 Thanks for your pull request @Ahsan144-tech, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
🙏 Thanks for your pull request @Ahsan144-tech, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
1 similar comment
🙏 Thanks for your pull request @Ahsan144-tech, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
hey this side Soham Das , i'm searching for repo with hacktoberfest tag will it accept pr for hacktoberfest25? |
Closed for no updates on the PR - feel free to create another one. |
Thank you for making a pull request to ZTM's Animation Nation project. We will review your pull request as soon as we can, but keep in mind we can get very busy during Hacktoberfest.
While you're waiting, please look over this checklist. Feel free to write a description of what you did as well!
What I did
Optional: Edit this to tell us what you did!
Pull request checklist
meta.json
file.<github_username>-<art_name>
without the <>.index.html
andstyles.css
.index.html
styles.css
meta.json
with:githubHandle
: being your unique github user name,artName
: name of your animationNot normally needed
Note: if your pull request makes an improvement besides adding a CSS animation you will need to discuss this with the maintainers. You can help kickstart this process by explaining what your change does and why you are making it in the "What I did" section
What to expect