eslint error fixed and npc character added #172
Conversation
|
🙏 Thanks for your pull request @yashpj, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
🙏 Thanks for your pull request @yashpj, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
| @@ -17,6 +17,7 @@ export const characters = [ | |||
| { name: 'jerry', frames: [160, 164, 162, 168, 161, 166] }, | |||
| { name: 'jordan', frames: [170, 174, 172, 178, 171, 176] }, | |||
| { name: 'jessie', frames: [180, 184, 182, 188, 181, 186] }, | |||
| { name: 'yash', frames: [100, 100, 100, 100, 100, 100] }, | |||
There was a problem hiding this comment.
Unfortunately, this doesn't work.
At the coordinates which you have provided, there is no character sprite.
You can add a entire new one by adding a new png file. Double check the setup here to get an idea how it works
| @@ -1,3 +1,4 @@ | |||
| // eslint-disable-next-line import/namespace | |||
There was a problem hiding this comment.
Thank you for this one. But it doesn't really add functionality to the project. It is not a mandatory change here.
|
Closed due to inactivity |
Hi this is my first pr.