Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added chest object #192

Closed
wants to merge 3 commits into from
Closed

added chest object #192

wants to merge 3 commits into from

Conversation

codewithsupra
Copy link

Added a chest object that gets more points

@zero-to-mastery-bot Zero To Mastery Bot
Copy link

🙏 Thanks for your pull request @codewithsupra, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
192 1745 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
4 27 94

@zero-to-mastery-bot Zero To Mastery Bot
Copy link

🙏 Thanks for your pull request @codewithsupra, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
192 1745 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
4 27 94

r4pt0s
r4pt0s requested changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@r4pt0s r4pt0s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codewithsupra there are a few changes to make in your PR.
Also, make sure you check the game with your changes locally with

npm run dev

To make sure there are no errors.

public/assets/sprites/chest.png Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not really a sprite. If looks more like a normal image which doesn't fit into the style which the entire game follows. Can you replace it with a 2D top-down pixel chest sprite?

src/gameObjects/map_start/chest.gameObject.js Outdated

return k.add([
k.sprite('chest'),
k.pos(map.pos.x + spawnpoints.chest.x, map.pos.y + spawnpoints.chest.y),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, there is no spawnpoint.chest available for now.
Have a look at other game object files to get an idea how you can place objects differently in such a case

yarn.lock Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the yarn.lock file because we use npm primarily for the project.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have added as a new branch. please check

@zero-to-mastery-bot Zero To Mastery Bot
Copy link

⚠️ MERGE CONFLICT DETECTED!

@codewithsupra A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, check out these videos by Aldo: How To Get Started With Open Source and How To Resolve Git Merge Conflicts. If you get stuck ask over on Discord.

1 similar comment
@zero-to-mastery-bot Zero To Mastery Bot
Copy link

⚠️ MERGE CONFLICT DETECTED!

@codewithsupra A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, check out these videos by Aldo: How To Get Started With Open Source and How To Resolve Git Merge Conflicts. If you get stuck ask over on Discord.

@zero-to-mastery-bot Zero To Mastery Bot
Copy link

🙏 Thanks for your pull request @codewithsupra, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
192 1764 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
6 27 94

1 similar comment
@zero-to-mastery-bot Zero To Mastery Bot
Copy link

🙏 Thanks for your pull request @codewithsupra, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
192 1764 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
6 27 94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r4pt0s r4pt0s r4pt0s requested changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codewithsupra @r4pt0s