Skip to content

Change to avoid Stopwatch allocation if timeout for PollNonBlocking is 0 #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change to avoid Stopwatch allocation if timeout for PollNonBlocking is 0 #134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion src/ZeroMQ/Poller.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ public int Poll(TimeSpan timeout)
{
return (int)timeout.TotalMilliseconds == Timeout.Infinite
? PollBlocking()
: PollNonBlocking(timeout);
: (int)timeout.TotalMilliseconds == 0 ? PollNonBlocking() : PollNonBlocking(timeout);
}

/// <summary>
Expand Down Expand Up @@ -212,6 +212,21 @@ private int PollNonBlocking(TimeSpan timeout)
return readyCount;
}

private int PollNonBlocking()
{
CreatePollItems();

var readyCount = Poll(0);
if (readyCount >= 0 || ErrorProxy.ContextWasTerminated)
{
return readyCount;
}

ContinueIfInterrupted();

return readyCount;
}

private void CreatePollItems()
{
if (_pollItems == null || _pollItems.Length != _pollableSockets.Count)
Expand Down