Skip to content

Add clang-format check in CI/CD and format all files #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add clang-format check in CI/CD and format all files #667

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9a7556e
Add clang-format check in CI/CD and format all files
cacharle Oct 16, 2025
8a68874
Add guard macros to workaround windows defined min/max instead of the…
cacharle Oct 17, 2025
e354989
Only run clang-format on Ubuntu 24 with clang-format 20
cacharle Oct 17, 2025
0ac1dca
Add pre-commit config
cacharle Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
libzmq: "4.3.5"
libzmqbuild: "cmake"
coverage: "-DCOVERAGE=ON"
aptinstall: "lcov clang-format"
aptinstall: "lcov"
# clang
- os: "ubuntu-22.04"
cppstd: "17"
Expand All @@ -61,7 +61,7 @@ jobs:
drafts: "OFF"
libzmq: "4.3.5"
libzmqbuild: false
brewinstall: "zeromq clang-format"
brewinstall: "zeromq"
# windows
#- os: "windows-2019"
# cppstd: "14"
Expand Down Expand Up @@ -133,9 +133,11 @@ jobs:
echo "LIBZMQ=${PWD}/libzmq-build" >> ${GITHUB_ENV}

- name: format
if: ${{ startsWith(matrix.os, 'ubuntu-24') }}
run: |
clang-format --version
git ls-files | grep -E '\.(cpp|hpp)' | xargs clang-format --dry-run --Werror
sudo apt install -y clang-format-20
clang-format-20 --version
git ls-files | grep -E '\.(cpp|hpp)' | xargs clang-format-20 --dry-run --Werror
Copy link
Contributor Author

@cacharle cacharle Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is running clang-format 20 only on Ubuntu okay?

Not sure how to solve the fact that people might have different versions installed..


- name: build
env:
Expand Down