fix: disable -Wshadow on gcc + fix useless cast warning

zeromq · Oct 23, 2024 · e1f0804 · e1f0804
1 parent ac41cdd
commit e1f0804
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -102,7 +102,11 @@ project_options(ENABLE_CACHE ENABLE_COMPILE_COMMANDS_SYMLINK)
 file(GLOB_RECURSE SOURCES "./src/*.cc")
 add_library(addon SHARED ${SOURCES})
 
-target_link_libraries(addon PRIVATE project_options) # project_warnings
+if(CMAKE_CXX_COMPILER_ID STREQUAL GNU)
+  target_compile_options(project_warnings INTERFACE "-Wno-shadow")
+endif()
+target_link_libraries(addon PRIVATE project_options project_warnings)
+
 
 if(ZMQ_DRAFT)
   target_compile_definitions(addon PRIVATE ZMQ_BUILD_DRAFT_API)

diff --git a/src/outgoing_msg.cc b/src/outgoing_msg.cc
@@ -44,7 +44,7 @@ OutgoingMsg::OutgoingMsg(Napi::Value value, Module& module) {
        but once converted we do not have to copy a second time. */
     auto string_send = [&](std::string* str) {
         auto length = str->size();
-        auto* data = const_cast<char*>(str->data());
+        auto* data = str->data();
 
         auto release = [](void*, void* str) {
             delete reinterpret_cast<std::string*>(str);