Update NFT/token to latest standard contracts #258
Conversation
📝 WalkthroughWalkthroughThe updates modify the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant LocalnetScript
participant UnderlyingScript
User->>LocalnetScript: Execute localnet.sh [no arguments]
LocalnetScript->>UnderlyingScript: Invoke underlying localnet.sh (no arguments)
UnderlyingScript-->>LocalnetScript: Execute logic
LocalnetScript-->>User: Complete
Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (3)
examples/nft/package.json (2)
59-60: See token example for Zeta dependency upgrades
These lines perform the same upgrades to@zetachain/protocol-contractsand@zetachain/standard-contracts. Refer to the token example review for compatibility verification steps.
62-62: See token example forvalidatordependency
Thevalidatorlibrary was introduced here as well; please verify its usage in the NFT example.examples/nft/scripts/localnet.sh (1)
3-3: See token example for CLI argument forwarding change
This mirrors the removal of$1forwarding in the token script. Confirm that the NFTlocalnet.shfromstandard-contractshandles being invoked without arguments.
🧹 Nitpick comments (1)
examples/token/package.json (1)
63-63: Alignzetachainversion specifier across examples
Herezetachainis pinned exactly to3.0.0, whereas in the NFT example it uses^3.0.0. Consider standardizing on a caret range (^3.0.0) for consistency and to allow patch updates.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
examples/nft/yarn.lockis excluded by!**/yarn.lock,!**/*.lockexamples/token/yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (4)
examples/nft/package.json(2 hunks)examples/nft/scripts/localnet.sh(1 hunks)examples/token/package.json(2 hunks)examples/token/scripts/localnet.sh(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: test (examples/swap)
- GitHub Check: test (examples/call)
- GitHub Check: slither (examples/swap, swap.sarif)
- GitHub Check: slither (examples/call, call.sarif)
- GitHub Check: slither (examples/hello, hello.sarif)
🔇 Additional comments (5)
examples/token/package.json (3)
9-9: Removeddeploy:localnetscript inscripts
Thedeploy:localnetentry was removed to streamline the example. Ensure any CI jobs, documentation, or README references to this script are updated accordingly.
59-60: Upgraded Zeta dependencies to new major versions
@zetachain/protocol-contractsand@zetachain/standard-contractswere bumped to stable releases (13.0.0and2.0.0-rc5). Verify that the example code aligns with any breaking changes introduced in these versions.
62-62: Confirm usage of newvalidatordependency
Thevalidatorlibrary was added here. Ensure it’s actually used in the example code; otherwise consider removing it to reduce unnecessary dependencies.examples/token/scripts/localnet.sh (1)
3-3: Removed forwarding of CLI argument$1
The script now invokes the Zeta localnet script without passing any parameters. Confirm that the underlyinglocalnet.shsupports being called without arguments and that no required configuration is lost.examples/nft/package.json (1)
9-9: Removeddeploy:localnetscript inscripts
Thedeploy:localnetentry has been removed. Ensure all example documentation and CI configurations are updated to reflect this removal.
Summary by CodeRabbit