Add VOLK_NAMESPACE configuration to use C++ namespaces #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
I can merge this if people find it useful. |
Owner
Author
|
Note: this would need to be rebased against #225 (assuming anybody needs this) before merge, as that PR splits the extern "C" block into two. |
|
This is a good idea, I observed using those globally defined extern functions triggers several linker errors with Clang/LLVM compilers on Windows. It is very weird and not being seen on GCC base toolchains. If we can just wrap all of those extern symbols inside some Macro like |
Owner
Author
|
For the latter I think you’d need something like #154? Together with VOLK_NO_PROTOTYPES. |
In some cases the use of global vk* symbols is inconvenient, as it can conflict with vk* functions defined by the loader; generally speaking this should not be required, but some dynamic library cases are difficult to support cleanly. This problem can be solved when C++ is available: by building volk.h/c as C++ and wrapping functions in volk namespace, which is automatically used, the compiler can still find the functions so no change in source code is necessary, but the global symbols get C++ mangling that never overlaps with vk*. This is not designed as a main mode of operation, but it can be useful when the default setup doesn't fully work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases the use of global vk* symbols is inconvenient, as it can conflict with vk* functions defined by the loader; generally speaking this should not be required, but some dynamic library cases are difficult to support cleanly.
This problem can be solved when C++ is available: by building volk.h/c as C++ and wrapping functions in volk namespace, which is automatically used, the compiler can still find the functions so no change in source code is necessary, but the global symbols get C++ mangling that never overlaps with vk*.
This is not designed as a main mode of operation, but it can be useful when the default setup doesn't fully work.