Skip to content

A basic remedy to issues reported as #167 and #191 #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

A basic remedy to issues reported as #167 and #191 #204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/cropper.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,16 @@ export default {
x = 1 - speed
}

// when a new image is loaded with the same aspect ratio
// as the previously remove()d one, the imgData.width and .height
// effectivelly don't change (they change through one tick
// and end up being the same as before the tick, so the
// watchers don't trigger), make sure scaleRatio isn't null so
// that zooming works...
if (this.scaleRatio === null) {
this.scaleRatio = this.imgData.width / this.naturalWidth
}

this.scaleRatio *= x
},

Expand Down