test: run flake8 with custom cfg to make it aware of flake8_quotes #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise flake8 might run without the flake8-quotes extension and doesn't report anything: | root@e519011a98e7:/code# flake8 --select=Q - < test/data/doubles.py | root@e519011a98e7:/code# Only when the flake8-quotes package is around, it behaves as expected: | root@e519011a98e7:/code# pip install --break-system-packages -e . | [...] | root@e519011a98e7:/code# flake8 --select=Q - < test/data/doubles.py | stdin:1:25: Q000 Double quotes found but single quotes preferred | stdin:2:25: Q000 Double quotes found but single quotes preferred | stdin:3:25: Q000 Double quotes found but single quotes preferred E.g. during a Debian package build we don't have the flake8-quotes package installed, though we can make flake8 aware of the local plugin through a configuration file. Fixes: | Traceback (most recent call last): | File "/<<PKGBUILDDIR>>/.pybuild/cpython3_3.12/build/test/test_checks.py", line 24, in test_stdin | self.assertEqual(len(stdout_lines), 3) | AssertionError: 0 != 3 Closes: zheller#122 Thanks: Chris Hofstaedtler <[email protected]> for assistance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise flake8 might run without the flake8-quotes extension and doesn't report anything:
Only when the flake8-quotes package is around, it behaves as expected:
E.g. during a Debian package build we don't have the flake8-quotes package installed, though we can make flake8 aware of the local plugin through a configuration file.
Fixes:
Closes: #122
Thanks: @zeha for assistance