Auto-refine loop for structure planner to reach coverage/dependency requirements#357
Open
zhongkaifu wants to merge 5 commits intomainfrom
Open
Auto-refine loop for structure planner to reach coverage/dependency requirements#357zhongkaifu wants to merge 5 commits intomainfrom
zhongkaifu wants to merge 5 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
finalize_workflowindicated more work was needed, causing misleading WARN messages and stopping further refinement.ready=True, within configured retry limits.Description
latest_finalize_feedbackandlatest_nodes_without_upstreamand expose them fromfinalize_workflow._run_agenthelper and an auto-refinewhileloop that reruns theAgentwith feedback, bounded bymax_coverage_refine_roundsandmax_dependency_refine_rounds.run_input, increment refinement counters, and log auto-refine rounds vialog_info.finalize_workflowwas never called versus when coverage/dependency checks failed and prepare the skeleton only after refinement stops.Testing
rg/sed) were used during development to locate related logic and verify edits, but these are not automated tests.Codex Task