Increase ask_ai max_rounds default to 5#360
Open
zhongkaifu wants to merge 1 commit intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ask_aisometimes returned{'status': 'error', 'results': {'message': 'ask_ai could not produce an answer within the allowed rounds'}}when it exhausted the default iteration budget.Description
max_roundsforask_aifrom3to5intools/builtin.pyby changing the function signature parametermax_rounds: int = 3tomax_rounds: int = 5.Testing
rg/sed) was used to locate and modify theask_aiimplementation prior to the change.ask_aiflows to validate the new default in environments that previously hit the round limit.Codex Task