Skip to content

Support nested output schemas in reference validation #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhongkaifu wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Support nested output schemas in reference validation #401

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2a0e93c
Support nested out param schemas
zhongkaifu Jan 17, 2026
314887a
Accept max_repair_rounds in planner
zhongkaifu Jan 17, 2026
cbdf18c
Avoid max_repair_rounds limiting analysis
zhongkaifu Jan 17, 2026
0be3845
Remove max_repair_rounds parameter
zhongkaifu Jan 17, 2026
dabfba1
Remove fixed temperature for check_workflow
zhongkaifu Jan 17, 2026
03e89c1
Handle dataclass validation errors in logs
zhongkaifu Jan 17, 2026
f12312b
Document nested out_params_schema shorthand
zhongkaifu Jan 17, 2026
edfb7da
Fix log_warn usage in orchestrator
zhongkaifu Jan 17, 2026
798ccba
Enforce loop body action node in check_workflow
zhongkaifu Jan 17, 2026
43021d4
Validate condition branch targets
zhongkaifu Jan 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions velvetflow/verification/binding_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,19 @@ def _index_actions_by_id(action_registry: List[Dict[str, Any]]) -> Dict[str, Dic
return {a["action_id"]: a for a in action_registry}


def _coerce_out_param_schema(value: Any) -> Mapping[str, Any]:
if isinstance(value, Mapping):
if any(key in value for key in ("type", "properties", "$schema")):
return value
properties = {key: _coerce_out_param_schema(item) for key, item in value.items()}
return {"type": "object", "properties": properties}
Comment on lines +26 to +31
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot Jan 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Treat non-type schema keywords as schemas, not objects

The new _coerce_out_param_schema treats any mapping that lacks type/properties/$schema as a nested object map, which changes the previous behavior for field-level schemas that only use other JSON Schema keywords (e.g., {"enum": [...]}, {"oneOf": [...]}, {"items": {...}}). Those were previously passed through as-is, but now get coerced into {type: object, properties: {enum: ...}}, so reference validation will interpret foo.enum as a property instead of applying the schema to foo. This breaks existing out_params_schema definitions that rely on keyword-only schemas; consider broadening the “already a schema” check to include other JSON Schema keywords.

Useful? React with 👍 / 👎.


if isinstance(value, str):
return {"type": value}

return {}


def _schema_from_out_params_schema(
out_params_schema: Mapping[str, Any] | None,
) -> Optional[Mapping[str, Any]]:
Expand All @@ -35,13 +48,9 @@ def _schema_from_out_params_schema(
if any(key in out_params_schema for key in ("type", "properties", "$schema")):
return out_params_schema

properties: Dict[str, Any] = {}
for key, value in out_params_schema.items():
if isinstance(value, Mapping):
properties[key] = value
else:
# Best-effort wrapper when only scalar types are provided.
properties[key] = {"type": value} if isinstance(value, str) else {}
properties: Dict[str, Any] = {
key: _coerce_out_param_schema(value) for key, value in out_params_schema.items()
}

return {"type": "object", "properties": properties}

Expand Down
Loading