Remove max_repair_rounds plumbing#402
Open
zhongkaifu wants to merge 4 commits intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
max_repair_roundssurface, so call sites and docs that passed or referenced this parameter were removed to keep the API consistent.Description
--max-repair-roundsCLI argument and stopped passingmax_repair_roundsintoupdate_workflow_with_two_passinupdate_workflow.py.max_repair_roundsarguments passed from example and server code by updatingbuild_workflow.pyandwebapp/server.pyto callplan_workflow_with_two_pass/update_workflow_with_two_passwithout the deprecated parameter.tests/test_update_workflow_planner.pyto match the new planner signature and revised the README text to drop themax_repair_roundsreference.Testing
Codex Task