Preserve unspecified node params on partial updates (recursive merge)#411
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
paramsfields that the caller did not specify, especially for nested structures.Description
_deep_merge_mappingand_merge_node_paramsto recursively merge incomingparamsonto existing nodeparamswhile preserving unspecified fields.update_action_node,update_reasoning_node,update_data_node,update_condition_node,update_switch_node, andupdate_loop_nodeby usingmerged_paramsas the input tofilter_supported_params.params.expressionagainst the merged params.tests/test_structure_update_node_partial_params.pythat simulates anupdate_action_nodecall updating only a nested field and asserts other nested fields remain unchanged.Testing
pytest -q tests/test_structure_update_node_partial_params.py tests/test_workflow_builder_update.py, and the test suite completed successfully (all tests passed).Codex Task