Write WHEEL tags in expanded form #40
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, pip maintainer here! 👋
The wheel specification requires that the
Tagfield contains all of the tags in their expanded form. Leaving the compressed form unchanged is usually "fine", but pip check (only!) misidentifies the wheel as incompatible with the system when fed a compressed wheel tag set. See also: pypa/pip#13709While I'm unfamiliar with this repository and can't test the build script directly, the tag expansion logic has been tested below.
Unfortunately, other projects seem to be copying ziglang's wheel build scripts so this oversight has spread across the ecosystem.