Skip to content

add dependent modules regardless of whether a runner was specified #23626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

elerch
Copy link
Contributor

@elerch elerch commented Apr 20, 2025

This addresses #23610 and very possibly #23453. The diff is semanticly equivalent to this diff, just cleaned up to remove the block that became unnecessary. All behavior tests pass.

diff --git i/src/main.zig w/src/main.zig
index 107599384..50363c68d 100644
--- i/src/main.zig
+++ w/src/main.zig
@@ -3040,7 +3040,6 @@ fn buildOutputType(
                 .builtin_mod = main_mod.getBuiltinDependency(),
                 .builtin_modules = null, // `builtin_mod` is specified
             });
-            test_mod.deps = try main_mod.deps.clone(arena);
             break :test_mod test_mod;
         } else try Package.Module.create(arena, .{
             .global_cache_directory = global_cache_directory,
@@ -3060,6 +3059,7 @@ fn buildOutputType(
             .builtin_modules = null, // `builtin_mod` is specified
         });

+        test_mod.deps = try main_mod.deps.clone(arena);
         break :root_mod test_mod;
     } else main_mod;

@alexrp alexrp requested a review from mlugg April 20, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant