std.Build: do not override properties of a package like named modules - #24879
Closed
Techatrix wants to merge 1 commit into
Closed
std.Build: do not override properties of a package like named modules#24879Techatrix wants to merge 1 commit into
Techatrix wants to merge 1 commit into
Conversation
The `addModule` function could override the module that is visible to dependants which most likely unintentional. Instead should asserts that no existing module has been added with the given name. The same issue applies to `addNamedWriteFiles` and `addNamedLazyPath`.
Member
|
This will have to be resubmitted on Codeberg once https://codeberg.org/ziglang/zig/issues/31691 is done. (We currently have a moratorium on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
addModulefunction could override the module that is visible to dependants which is most likely unintentional. Instead it should assert that no existing module has been added with the given name.The same issue applies to
addNamedWriteFilesandaddNamedLazyPath.