-
Notifications
You must be signed in to change notification settings - Fork 888
Add Third Reality curtain gen2 settings #4381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #4381 +/- ##
=======================================
Coverage 92.12% 92.13%
=======================================
Files 358 359 +1
Lines 11917 11929 +12
=======================================
+ Hits 10979 10991 +12
Misses 938 938 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few small things, otherwise good already!
Co-authored-by: TheJulianJES <[email protected]>
Co-authored-by: TheJulianJES <[email protected]>
Co-authored-by: TheJulianJES <[email protected]>
Co-authored-by: TheJulianJES <[email protected]>
@TheJulianJES Thank you for your reply. The modifications have been made. Everything else is fine |
Proposed change
This PR added adaptation code for curtain gen2 and added 2 additional private clusters
Additional information
Device diagnostics
Checklist
pre-commit
checks pass / the code has been formatted using Black