fix: require setuptools>=83 and milvus-lite>=3.0 (CVE-2026-59890) - #639
Open
j-sperling wants to merge 2 commits into
Open
fix: require setuptools>=83 and milvus-lite>=3.0 (CVE-2026-59890)#639j-sperling wants to merge 2 commits into
j-sperling wants to merge 2 commits into
Conversation
The setuptools<81 cap (added for PYSEC-2025-49) now blocks upgrading past CVE-2026-59890, which is fixed in setuptools 83. The cap exists because milvus-lite 2.5.x imports pkg_resources, which setuptools 83 removes; milvus-lite 3.0 drops that import, so the two floors have to move together. milvus-lite 3.0 no longer persists collection descriptions, so the description round-trip test accepts write-only behavior. The resolver also floats torch to 2.13 in the local extra because torch 2.12.1 pins setuptools<81.
yxtay
approved these changes
Jul 25, 2026
…milvus-lite-3 # Conflicts: # pyproject.toml
Contributor
Author
|
Merged current main (c0984a0) to clear the conflict: kept main's new Two things worth an explicit ack in review, both consequences of the floor change rather than incidental churn:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setuptools>=78.1.1,<81pin (added for PYSEC-2025-49) now blocks upgrading past CVE-2026-59890, which is fixed in setuptools 83, so every memsearch install resolves a vulnerable setuptools.<81cap exists because milvus-lite 2.5.x importspkg_resources, which setuptools 83 removes. milvus-lite 3.0 drops that import, so the two floors have to move together:setuptools>=83paired withmilvus-lite>=3.0.localextra because torch 2.12.1 pinssetuptools<81..dbfiles from the 2.5.x storage format (already covered by the "Milvus Lite collection is released" troubleshooting entry — users rebuild from source markdown).We have been running this combination without issues.
Test plan
ruff check/ruff format --checkcleanuv lockregenerated from the new floors;uv lock --checkclean