Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the metric and fix the mq seek error #29

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Conversation

SimFG
Copy link
Collaborator

@SimFG SimFG commented Nov 23, 2023

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #29 (7c01913) into main (e346111) will decrease coverage by 0.02%.
The diff coverage is 16.66%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   81.55%   81.53%   -0.02%     
==========================================
  Files          39       39              
  Lines        4082     4083       +1     
==========================================
  Hits         3329     3329              
- Misses        627      628       +1     
  Partials      126      126              
Files Coverage Δ
server/cdc_impl.go 64.21% <0.00%> (-0.09%) ⬇️
core/reader/replicate_channel_manager.go 79.96% <20.00%> (ø)

@SimFG SimFG merged commit 79f3ff5 into zilliztech:main Nov 23, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants