Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trace optimizer to ZnRND #73

Merged
merged 4 commits into from
Jan 4, 2023
Merged

Add trace optimizer to ZnRND #73

merged 4 commits into from
Jan 4, 2023

Conversation

SamTov
Copy link
Member

@SamTov SamTov commented Jan 2, 2023

I have written in the trace normalized optimizer so that it can be called directly and we don't need to keep writing custom train loops. There is also a test written in.

@SamTov SamTov requested review from jhossbach and KonstiNik and removed request for jhossbach January 2, 2023 14:41
Copy link
Member

@KonstiNik KonstiNik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice and clean implementation of your optimizer.

I have one bigger comment to how it re-scales.
The rest are just minor things and suggestions.

Copy link
Collaborator

@jhossbach jhossbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, otherwise

LGTM

@SamTov
Copy link
Member Author

SamTov commented Jan 3, 2023

Very nice and clean implementation of your optimizer.

I have one bigger comment to how it re-scales. The rest are just minor things and suggestions.

I responded to that one in some detail. But in general that is a topic of research. All learning rates ignore batch size and this one does the same. We only notice it because we now care about the batch in the training dynamics. However, I can add an argument that allows for scaling over the batch or anything so that we can experiment with this very easily.

@SamTov SamTov merged commit eef920d into main Jan 4, 2023
@SamTov SamTov deleted the SamTov_add_trace_optimizer branch January 4, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants