Open
Conversation
zancas
reviewed
Mar 26, 2026
| use crate::config::{ChainType, ClientConfig}; | ||
| use crate::config::ChainType; | ||
| use crate::config::ClientConfig; | ||
| use zingo_common_components::protocol::ActivationHeights; |
Member
There was a problem hiding this comment.
Is this the type we prefer for this?
Contributor
Author
There was a problem hiding this comment.
IDK, this PR didnt change that aspect, it only is imported here to complete a unit test.
Oscar-Pepper
requested changes
Mar 27, 2026
| /// Invalid chain type. | ||
| #[derive(thiserror::Error, Debug)] | ||
| #[error("Invalid chain type '{0}'. Expected one of: 'mainnet', 'testnet' or 'regtest'.")] | ||
| pub struct InvalidChainType(String); |
Contributor
There was a problem hiding this comment.
i dont understand why this has moved in between the ChainType impls? please can we keep the impls together
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chaintype is now open to be inferred from Indexer.