Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable decoding of 256 bit numbers (#1053) #1134

Open
wants to merge 2 commits into
base: series/2.x
Choose a base branch
from
Open

fix: enable decoding of 256 bit numbers (#1053) #1134

wants to merge 2 commits into from

Conversation

abhishek818
Copy link

fixes #1053

/claim #1053

@abhishek818 abhishek818 requested a review from a team as a code owner June 28, 2024 14:20
@algora-pbc algora-pbc bot mentioned this pull request Jun 28, 2024
Closed
@abhishek818
Copy link
Author

@jdegoes Up for review.

@abhishek818
Copy link
Author

abhishek818 commented Jun 28, 2024 •
edited
Loading

I have simply reconfigured the limit to 256 here,
should we provide a config to set the limit (not sure how? also it can lead to other problems) OR
should I look in the direction of a custom decoder OR
or increase the const to some other higher no. ?

@jdegoes @987Nabil

@abhishek818
Copy link
Author

@jdegoes hey can you review this?

@fsvehla
Copy link
Contributor

fsvehla commented Sep 1, 2024

@abhishek818 Can you check what’s up with the huge diff in lexer.scala, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🙋 Bounty claim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't decode 256bit numbers
2 participants
@abhishek818 @fsvehla