Strip parameter and fix relative link. #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexdraconian
commented
Mar 1, 2021
alexdraconian
commented
- Strip parameter as well as anchor.
- Fix tooltip not working for relative link.
1. Strip parameter as well as anchor. 2. Fix tooltip not working for relative link.
Resolve link id before passing to helper
zioth
reviewed
Mar 1, 2021
Comment on lines
+51
to
+54
| resolve_pageid(getNS($ID), $id, $exists); | ||
|
|
||
| global $ID; | ||
| if (!$this->m_helper->isExcluded($ID) && page_exists($id) && $id != $ID) { | ||
| if (!$this->m_helper->isExcluded($ID) && $exists && $id != $ID) { |
Author
There was a problem hiding this comment.
If there're relative links, autotooltip did not recognize them as relative link, but absolute link.
Example:
In "namespace:some_page", there're link like "[[other_page]]".
Since this is relative link, this link should be resolved as ":namespace:other_page".
However autotooltip resolved as ":other_page" and consider linked page does not exist.
So I re-positioned link resolve logic to early stage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.