Skip to content

chore: improve idp integration using server action #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2025

Conversation

yordis
Copy link
Contributor

@yordis yordis commented Dec 27, 2024

No description provided.

Copy link

vercel bot commented Dec 27, 2024

@yordis is attempting to deploy a commit to the zitadel Team on Vercel.

A member of the Team first needs to authorize it.

@yordis yordis marked this pull request as ready for review December 27, 2024 16:56
@muhlemmer muhlemmer requested a review from peintnermax January 6, 2025 12:37
@yordis yordis force-pushed the improve-actions branch 3 times, most recently from e5fa4d6 to 942bb28 Compare January 22, 2025 17:53
@yordis
Copy link
Contributor Author

yordis commented Jan 22, 2025

@peintnermax CI passing!

@peintnermax
Copy link
Member

thx for the PR @yordis . Could we move the server action to the lib/server/idp.ts and eventually remove the startIDPFlow function as it will not be invoked anymore?

@yordis yordis requested a review from peintnermax January 23, 2025 15:35
@muhlemmer muhlemmer moved this from 👀 In review to 📨 Product Backlog in Product Management Feb 26, 2025
@yordis yordis requested a review from tafaust March 16, 2025 19:03
@yordis
Copy link
Contributor Author

yordis commented Apr 10, 2025

Hey @peintnermax could we take this PR?

Copy link

vercel bot commented Apr 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
typescript-login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2025 7:34am

Copy link
Member

@peintnermax peintnermax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx @yordis and sorry for the delay! 😎

@peintnermax peintnermax merged commit f894151 into zitadel:main Apr 16, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this from 📨 Product Backlog to ✅ Done in Product Management Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants